RUM-10224: Add dd-octo-sts to Dockerfile#2739
Merged
aleksandr-gringauz merged 1 commit intoJun 19, 2025
Merged
Conversation
aleksandr-gringauz
marked this pull request as ready for review
June 19, 2025 08:30
aleksandr-gringauz
force-pushed
the
aleksandr-gringauz/RUM-10224/add-dd-octo-sts-to-dockerfile
branch
from
June 19, 2025 08:31
d55b36c to
ec578f7
Compare
0xnm
previously approved these changes
Jun 19, 2025
aleksandr-gringauz
force-pushed
the
aleksandr-gringauz/RUM-10224/add-dd-octo-sts-to-dockerfile
branch
from
June 19, 2025 09:32
ec578f7 to
7797f90
Compare
| # Install pip for aws | ||
| RUN set -x \ | ||
| && curl -OL https://bootstrap.pypa.io/get-pip.py \ | ||
| && curl -OL https://bootstrap.pypa.io/pip/3.8/get-pip.py \ |
Contributor
Author
There was a problem hiding this comment.
ci-image job failed
0.137 ERROR: This script does not work on Python 3.8. The minimum supported Python version is 3.9. Please use https://bootstrap.pypa.io/pip/3.8/get-pip.py instead.
I didn't dig deep, but probably this https://bootstrap.pypa.io/get-pip.py changed and started failing.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2739 +/- ##
==========================================
Coverage ? 69.69%
==========================================
Files ? 824
Lines ? 30790
Branches ? 5177
==========================================
Hits ? 21459
Misses ? 7861
Partials ? 1470 🚀 New features to boost your workflow:
|
0xnm
approved these changes
Jun 19, 2025
aleksandr-gringauz
deleted the
aleksandr-gringauz/RUM-10224/add-dd-octo-sts-to-dockerfile
branch
June 19, 2025 11:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adding dd-octo-sts to our dockerfile so that our GitLab CI can use it. Docs
I haven't decided how everything will look like yet, but this will definitely be needed, so will start from this.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)