RUM-10413: Mark CoreFeature properties used to create DatadogContext as volatile#2738
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## nogorodnikov/rum-8170/feature-context-sync #2738 +/- ##
==============================================================================
- Coverage 69.83% 69.79% -0.04%
==============================================================================
Files 824 824
Lines 30936 30931 -5
Branches 5188 5188
==============================================================================
- Hits 21604 21588 -16
- Misses 7855 7868 +13
+ Partials 1477 1475 -2
🚀 New features to boost your workflow:
|
aleksandr-gringauz
approved these changes
Jun 19, 2025
0xnm
merged commit Jun 19, 2025
e531526
into
nogorodnikov/rum-8170/feature-context-sync
24 checks passed
0xnm
deleted the
nogorodnikov/rum-10413/mark-corefeature-properties-participating-in-datadogcontext-as-volatile
branch
June 19, 2025 08:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We need to mark some properties of
CoreFeatureas volatile: they are set from one thread and will be read from another thread - context processing thread.Review checklist (to be filled by reviewers)