Fix Jetpack compose auto instrumentation telemetry in benchmark app#2737
Merged
aleksandr-gringauz merged 1 commit intoJun 18, 2025
Merged
Conversation
aleksandr-gringauz
changed the title
aleksandr-gringauz
marked this pull request as ready for review
June 18, 2025 13:35
ambushwork
approved these changes
Jun 18, 2025
0xnm
approved these changes
Jun 18, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2737 +/- ##
===========================================
- Coverage 69.78% 69.75% -0.03%
===========================================
Files 824 824
Lines 30790 30790
Branches 5177 5177
===========================================
- Hits 21485 21476 -9
- Misses 7833 7857 +24
+ Partials 1472 1457 -15 🚀 New features to boost your workflow:
|
aleksandr-gringauz
deleted the
aleksandr-gringauz/fix-compose-telemetry-benchmark
branch
June 18, 2025 14:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
@ambushwork noticed that this telemetry stopped being sent from the Benchmark app.
It coincided by time with this merging of this pr.
The problem is that I introduced a custom sdk core name and the
sendTelemetryfunction uses defaultDatadogSdkCoreinstance. It was not found and silently substituted byNoOpInternalSdkCorethat didn't send any logs.The fix is to use the default singleton without a custom name.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)