Skip to content

RUM-10224: Introduce check release pipeline#2731

Merged
aleksandr-gringauz merged 5 commits into
developfrom
aleksandr-gringauz/RUM-10224/github-app-migration-for-pat-synthetics
Jun 17, 2025
Merged

RUM-10224: Introduce check release pipeline#2731
aleksandr-gringauz merged 5 commits into
developfrom
aleksandr-gringauz/RUM-10224/github-app-migration-for-pat-synthetics

Conversation

@aleksandr-gringauz

@aleksandr-gringauz aleksandr-gringauz commented Jun 16, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

This pr is based on another pr that isn't merged yet.

This pr migrates this synthetic test to GitLab CI.

This synthetic test does the following:

  1. Got the latest version from dd-sdk-android repo using GitHub REST API.
  2. Checked that for each module that we publish we have a corresponding artifact published to mavenCentral.

Now the same thing is done using:

  1. Pipeline schedule link.
  2. example of a successful run link
  3. Docs
  4. The schedule I created now looks at the branch of this pr, I'll recreate it to look at the develop branch when pr is merged.

Implementation details:

  1. I created a separate pipeline in file check-release-pipeline.yml.
  2. The original ci pipeline was moved from gitlab-ci.yml to default-pipeline.yml.
  3. gitlab-ci.yml became the entry point that decides which pipeline to execute based on CI_PIPELINE_KEY which is set in the link.
  4. if CI_PIPELINE_KEY == null the default pipeline is executed.
  5. Moved ci related yml files and scripts to ci folder for more order.
  6. Also see comments in the pr.

Other solutions:

  1. It is possible to do the same thing using GitHub Actions, but it is more or less the same as current solution. I don't think it is a good idea to introduce GitHub CI when we already do everything in GitLab.
  2. There is no such thing (AFAIK) as "Launch a GitHub app". You can create a web app that interacts with GitHub API using the installation token, use GitHub Actions using this token, or use GitLab in the same way.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@aleksandr-gringauz
aleksandr-gringauz force-pushed the aleksandr-gringauz/RUM-10224/github-app-migration-for-pat-synthetics branch from 7b51cfb to 570300b Compare June 16, 2025 14:29
aleksandr-gringauz
aleksandr-gringauz commented Jun 16, 2025
View reviewed changes
Comment thread ci/pipelines/common-snippets.yml
@@ -0,0 +1,5 @@
.common-snippets:

@aleksandr-gringauz aleksandr-gringauz Jun 16, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extracted this to a separate file so that it can be reused both in the default-pipeline.yml and check-release-pipeline.yml.

@codecov-commenter

codecov-commenter commented Jun 16, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.70%. Comparing base (db25ca2) to head (0a5ebef).

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2731      +/-   ##
===========================================
- Coverage    69.83%   69.70%   -0.13%     
===========================================
  Files          824      824              
  Lines        30774    30774              
  Branches      5173     5173              
===========================================
- Hits         21489    21449      -40     
- Misses        7823     7864      +41     
+ Partials      1462     1461       -1

see 38 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aleksandr-gringauz
aleksandr-gringauz force-pushed the aleksandr-gringauz/RUM-10224/github-app-migration-for-pat-synthetics branch from 570300b to 3141a0e Compare June 16, 2025 14:51
aleksandr-gringauz
aleksandr-gringauz commented Jun 16, 2025
View reviewed changes
Comment thread ci/pipelines/default-pipeline.yml
@@ -0,0 +1,1030 @@
include:

@aleksandr-gringauz aleksandr-gringauz Jun 16, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are no changes here except moving set-github-installation-token into common-snippets and fixing the paths to moved scripts.

@ambushwork ambushwork Jun 16, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: next time you can separate modification and moving codes into two commits, it will be easier for reviewing the diff part.

@aleksandr-gringauz
aleksandr-gringauz marked this pull request as ready for review June 16, 2025 14:56
@aleksandr-gringauz
aleksandr-gringauz requested review from a team as code owners June 16, 2025 14:56
ambushwork
ambushwork reviewed Jun 16, 2025
View reviewed changes
Comment thread ci/pipelines/default-pipeline.yml
@@ -0,0 +1,1030 @@
include:

@ambushwork ambushwork Jun 16, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: next time you can separate modification and moving codes into two commits, it will be easier for reviewing the diff part.

Comment thread ci/scripts/check_latest_release_is_published.sh Outdated
Comment thread ci/pipelines/default-pipeline.yml
Base automatically changed from aleksandr-gringauz/RUM-10224/github-app-migration-for-pat to develop June 17, 2025 08:09
ambushwork
ambushwork previously approved these changes Jun 17, 2025
View reviewed changes

@ambushwork ambushwork left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

0xnm
0xnm previously approved these changes Jun 17, 2025
View reviewed changes
Comment thread ci/pipelines/default-pipeline.yml
Comment thread ci/pipelines/check-release-pipeline.yml
Comment thread ci/scripts/check_latest_release_is_published.sh Outdated
@aleksandr-gringauz
aleksandr-gringauz dismissed stale reviews from 0xnm and ambushwork via f90e816 June 17, 2025 09:40
0xnm
0xnm previously approved these changes Jun 17, 2025
View reviewed changes
Comment thread build.gradle.kts Outdated
@aleksandr-gringauz
aleksandr-gringauz merged commit c13cf84 into develop Jun 17, 2025
25 checks passed
@aleksandr-gringauz
aleksandr-gringauz deleted the aleksandr-gringauz/RUM-10224/github-app-migration-for-pat-synthetics branch June 17, 2025 12:37
@aleksandr-gringauz aleksandr-gringauz mentioned this pull request Jun 30, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes
@ambushwork ambushwork ambushwork approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aleksandr-gringauz @codecov-commenter @0xnm @ambushwork