Fix RumSessionScope flaky test#2730
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2730 +/- ##
===========================================
- Coverage 69.81% 69.78% -0.03%
===========================================
Files 824 824
Lines 30774 30774
Branches 5173 5173
===========================================
- Hits 21483 21473 -10
- Misses 7827 7841 +14
+ Partials 1464 1460 -4 🚀 New features to boost your workflow:
|
ambushwork
marked this pull request as ready for review
June 16, 2025 09:13
0xnm
approved these changes
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Some
SdkInitevents can trigger renew session and some will not, so instead of verifying that "renew session then no more interaction", we can just verify that "handle event is never called on child scope".Review checklist (to be filled by reviewers)