RUM-10348: Remove feature name argument from APIs to set/remove feature context update listener#2729
Merged
Conversation
…re context update listener
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## nogorodnikov/rum-8170/feature-context-sync #2729 +/- ##
==============================================================================
- Coverage 69.87% 69.83% -0.05%
==============================================================================
Files 824 824
Lines 30947 30934 -13
Branches 5190 5188 -2
==============================================================================
- Hits 21624 21600 -24
+ Misses 7859 7855 -4
- Partials 1464 1479 +15
🚀 New features to boost your workflow:
|
aleksandr-gringauz
approved these changes
Jun 13, 2025
Base automatically changed from
nogorodnikov/rum-10347/avoid-polling-for-rumcontext-in-vital-runnable
to
nogorodnikov/rum-8170/feature-context-sync
June 16, 2025 16:43
0xnm
merged commit Jun 16, 2025
1b90579
into
nogorodnikov/rum-8170/feature-context-sync
24 of 25 checks passed
0xnm
deleted the
nogorodnikov/rum-10348/remove-feature-name-argument-from-add-remove-featurecontextupdate-receiver
branch
June 16, 2025 16:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes
featureNameargument fromFeatureSdkCore.setFeatureContextUpdateReceiverandFeatureSdkCore.removeFeatureContextUpdateReceiverAPIs, because it is not needed anymore after feature context handling is reworked.FeatureContextUpdateReceivertype is broadcast type anyway.Note: there is some inconsistency in the
receivervslistenerusage andsetFeatureContextUpdateReceiverAPI instead ofaddFeatureContextUpdateReceiverAPI when there isremoveFeatureContextUpdateReceiverAPI, but changing this is not a point of this change.Review checklist (to be filled by reviewers)