Add integration tests of set account information in reliability module#2725
Merged
Conversation
ambushwork
force-pushed
the
yl/account-info/single-fit
branch
from
June 12, 2025 15:37
9350e22 to
a39a513
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2725 +/- ##
===========================================
- Coverage 69.78% 69.77% -0.00%
===========================================
Files 825 825
Lines 30760 30759 -1
Branches 5174 5173 -1
===========================================
- Hits 21463 21462 -1
+ Misses 7842 7840 -2
- Partials 1455 1457 +2 🚀 New features to boost your workflow:
|
ambushwork
marked this pull request as ready for review
June 13, 2025 06:48
0xnm
requested changes
Jun 13, 2025
0xnm
left a comment
0xnm
left a comment
Member
There was a problem hiding this comment.
lgtm, but we also need to add tests in the single-fit for RUM, Logs and Traces.
ambushwork
force-pushed
the
yl/account-info/single-fit
branch
4 times, most recently
from
June 13, 2025 15:45
197b2c4 to
df2c69e
Compare
0xnm
previously approved these changes
Jun 16, 2025
ambushwork
force-pushed
the
yl/account-info/single-fit
branch
from
June 16, 2025 11:33
df2c69e to
4ef04d1
Compare
0xnm
approved these changes
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add integration tests of set account information in reliability module
Review checklist (to be filled by reviewers)