Xgouchet/automotive#2722
Closed
xgouchet wants to merge 2 commits into
Closed
Conversation
0xnm
reviewed
Jun 12, 2025
Member
There was a problem hiding this comment.
maybe we should create a folder sample/automotive instead of sample/auto? Android Auto is a different thing, so it may be a confusion here by looking on the name.
| configureFlavorForAutoApp(project.rootDir) | ||
| } | ||
|
|
||
| namespace = "com.datadog.sample.auto" |
Member
There was a problem hiding this comment.
following the suggestion above
Suggested change
| namespace = "com.datadog.sample.auto" | |
| namespace = "com.datadog.sample.automotive" |
| implementation(project(":integrations:dd-sdk-android-okhttp-otel")) | ||
|
|
||
| // Desugaring SDK | ||
| coreLibraryDesugaring(libs.androidDesugaringSdk) |
Member
There was a problem hiding this comment.
do we need this if min API is 29? It should be good for Otel support already.
| android:value="1"/> | ||
| </application> | ||
|
|
||
| </manifest> No newline at end of file |
Member
There was a problem hiding this comment.
minor: missing newline at the EOF. This applies also to other XML files here.
Suggested change
| </manifest> | |
| </manifest> | |
xgouchet
force-pushed
the
xgouchet/automotive
branch
from
June 12, 2025 14:13
10d6071 to
c279aa9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A adds a sample app for automotive support