Fix GsonExt flaky test#2719
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2719 +/- ##
===========================================
- Coverage 69.85% 69.81% -0.04%
===========================================
Files 823 823
Lines 30626 30626
Branches 5157 5157
===========================================
- Hits 21391 21380 -11
- Misses 7785 7797 +12
+ Partials 1450 1449 -1 🚀 New features to boost your workflow:
|
ambushwork
marked this pull request as ready for review
June 11, 2025 14:48
0xnm
approved these changes
Jun 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
forge.aString()can generate numerical string like: "1", "23", etc, which make test fail,change to
anAlphabeticalStringwhich doesn't contain any number.Review checklist (to be filled by reviewers)