Skip to content

Remove ContentPainterElement Class Reflection from Telemetry#2714

Merged
ambushwork merged 1 commit into
developfrom
yl/adjust-compose-reflection-telemetry
Jun 11, 2025
Merged

Remove ContentPainterElement Class Reflection from Telemetry#2714
ambushwork merged 1 commit into
developfrom
yl/adjust-compose-reflection-telemetry

Conversation

@ambushwork

Copy link
Copy Markdown
Member

What does this PR do?

ContentPainterElement class reflection contributes a high volume to our telemetry log while we don't have any action on that, because it becomes a normal case if the client is using coil3 instead of coil2, so removing it from Telemetry

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@ambushwork
ambushwork marked this pull request as ready for review June 10, 2025 08:38
@ambushwork
ambushwork requested review from a team as code owners June 10, 2025 08:38
@codecov-commenter

codecov-commenter commented Jun 10, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 69.85%. Comparing base (d7410ff) to head (5b6c2e1).
Report is 113 commits behind head on develop.

Files with missing lines Patch % Lines
...y/compose/internal/reflection/ComposeReflection.kt 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2714      +/-   ##
===========================================
+ Coverage    69.84%   69.85%   +0.01%     
===========================================
  Files          823      823              
  Lines        30624    30626       +2     
  Branches      5157     5157              
===========================================
+ Hits         21389    21393       +4     
- Misses        7784     7789       +5     
+ Partials      1451     1444       -7     
Files with missing lines Coverage Δ
...y/compose/internal/reflection/ComposeReflection.kt 0.00% <0.00%> (ø)

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ambushwork
ambushwork merged commit dc4ab79 into develop Jun 11, 2025
26 checks passed
@ambushwork
ambushwork deleted the yl/adjust-compose-reflection-telemetry branch June 11, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants