Skip to content

RUM-9917 improve speed of running core-it suite#2711

Merged
xgouchet merged 1 commit into
developfrom
xgouchet/RUM-9917/speed_up_core_it_tests
Jun 6, 2025
Merged

RUM-9917 improve speed of running core-it suite#2711
xgouchet merged 1 commit into
developfrom
xgouchet/RUM-9917/speed_up_core_it_tests

Conversation

@xgouchet

@xgouchet xgouchet commented Jun 6, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

Speed up the core-it test suite and reduce the time spent in CI

@xgouchet
xgouchet requested review from a team as code owners June 6, 2025 13:49
@codecov-commenter

codecov-commenter commented Jun 6, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.94%. Comparing base (60a1945) to head (1beedef).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2711      +/-   ##
===========================================
- Coverage    69.96%   69.94%   -0.01%     
===========================================
  Files          822      822              
  Lines        30639    30639              
  Branches      5158     5158              
===========================================
- Hits         21434    21430       -4     
- Misses        7765     7772       +7     
+ Partials      1440     1437       -3     

see 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ambushwork
ambushwork previously approved these changes Jun 6, 2025
}
.setBatchSize(forge.getForgery())
.setUploadFrequency(forge.getForgery())
.setBatchSize(BatchSize.SMALL)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably it should be different here? Like big batches + setBatchProcessingLevel(BatchProcessingLevel.HIGH), since we want to upload as much as possible as fast as possible.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smaller batches means that they are ready to be uploaded faster.
Good idea on setBatchProcessingLevel, I'll update the PR

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smaller batches means that they are ready to be uploaded faster

oh yeah, this is true as well. We can have more upload iterations for them, but BatchProcessingLevel.HIGH should solve that.

@xgouchet
xgouchet requested a review from satween June 6, 2025 14:39
@xgouchet
xgouchet force-pushed the xgouchet/RUM-9917/speed_up_core_it_tests branch from 6d9e208 to 1beedef Compare June 6, 2025 14:45
@xgouchet
xgouchet requested review from 0xnm and ambushwork June 6, 2025 14:45
@xgouchet
xgouchet merged commit d7410ff into develop Jun 6, 2025
25 of 26 checks passed
@xgouchet
xgouchet deleted the xgouchet/RUM-9917/speed_up_core_it_tests branch June 6, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants