Skip to content

RUM-10278: Add account information in Trace#2709

Merged
ambushwork merged 1 commit into
feature/account-infofrom
yl/account-info/add-to-traces
Jun 6, 2025
Merged

RUM-10278: Add account information in Trace#2709
ambushwork merged 1 commit into
feature/account-infofrom
yl/account-info/add-to-traces

Conversation

@ambushwork

@ambushwork ambushwork commented Jun 6, 2025

Copy link
Copy Markdown
Member

What does this PR do?

Add account information in Trace module

Motivation

RUM-10278

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@ambushwork
ambushwork force-pushed the yl/account-info/add-to-traces branch 2 times, most recently from b5bdbfe to c7b61b8 Compare June 6, 2025 11:45
@ambushwork
ambushwork marked this pull request as ready for review June 6, 2025 11:50
@ambushwork
ambushwork requested review from a team as code owners June 6, 2025 11:50
0xnm
0xnm previously approved these changes Jun 6, 2025
View reviewed changes
@ambushwork
ambushwork force-pushed the yl/account-info/add-to-traces branch from c7b61b8 to 46f88a8 Compare June 6, 2025 12:10
@codecov-commenter

codecov-commenter commented Jun 6, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.97%. Comparing base (54341cd) to head (46f88a8).

Files with missing lines Patch % Lines
...al/domain/event/CoreTracerSpanToSpanEventMapper.kt 66.67% 0 Missing and 1 partial ⚠️
...e/internal/domain/event/DdSpanToSpanEventMapper.kt 66.67% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@                   Coverage Diff                    @@
##           feature/account-info    #2709      +/-   ##
========================================================
+ Coverage                 69.94%   69.97%   +0.03%     
========================================================
  Files                       824      824              
  Lines                     30743    30753      +10     
  Branches                   5172     5174       +2     
========================================================
+ Hits                      21503    21518      +15     
+ Misses                     7789     7785       -4     
+ Partials                   1451     1450       -1
Files with missing lines Coverage Δ
...trace/internal/domain/event/BaseSpanEventMapper.kt 95.12% <100.00%> (+5.93%) ⬆️
...al/domain/event/CoreTracerSpanToSpanEventMapper.kt 93.33% <66.67%> (-0.92%) ⬇️
...e/internal/domain/event/DdSpanToSpanEventMapper.kt 92.16% <66.67%> (-1.59%) ⬇️

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ambushwork
ambushwork merged commit 03ab092 into feature/account-info Jun 6, 2025
@ambushwork
ambushwork deleted the yl/account-info/add-to-traces branch June 6, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes
+1 more reviewer
@xgouchet xgouchet xgouchet approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ambushwork @codecov-commenter @xgouchet @0xnm