Skip to content

Move public top-level extension functions and properties from core module to internal module#2707

Merged
0xnm merged 1 commit into
developfrom
nogorodnikov/move-top-level-functions-and-properties-060625
Jun 6, 2025
Merged

Move public top-level extension functions and properties from core module to internal module#2707
0xnm merged 1 commit into
developfrom
nogorodnikov/move-top-level-functions-and-properties-060625

Conversation

@0xnm

@0xnm 0xnm commented Jun 6, 2025

Copy link
Copy Markdown
Member

What does this PR do?

This PR moves public top-level extension functions and properties annotated with @InternalApi from core module to internal module to avoid exposing them in the user space.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested review from a team as code owners June 6, 2025 07:32
ambushwork
ambushwork previously approved these changes Jun 6, 2025
View reviewed changes
Base automatically changed from nogorodnikov/move-local-attributes-and-extension-method-to-internal-module to develop June 6, 2025 08:55
@0xnm
0xnm dismissed ambushwork’s stale review June 6, 2025 08:55

The base branch was changed.

@0xnm
0xnm requested a review from ambushwork June 6, 2025 08:55
@codecov-commenter

codecov-commenter commented Jun 6, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.89%. Comparing base (8cda755) to head (cee64de).
⚠️ Report is 1004 commits behind head on develop.

Files with missing lines Patch % Lines
...va/com/datadog/android/internal/utils/ThreadExt.kt 0.00% 8 Missing ⚠️
...va/com/datadog/android/internal/utils/NumberExt.kt 0.00% 3 Missing ⚠️
...ava/com/datadog/android/internal/utils/MapUtils.kt 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2707      +/-   ##
===========================================
- Coverage    69.90%   69.89%   -0.01%     
===========================================
  Files          822      823       +1     
  Lines        30639    30624      -15     
  Branches      5158     5157       -1     
===========================================
- Hits         21416    21402      -14     
- Misses        7776     7777       +1     
+ Partials      1447     1445       -2
Files with missing lines Coverage Δ
...n/com/datadog/android/core/internal/CoreFeature.kt 87.35% <ø> (ø)
...om/datadog/android/core/internal/utils/MapUtils.kt 50.00% <ø> (-16.67%) ⬇️
...m/datadog/android/core/internal/utils/NumberExt.kt 100.00% <ø> (+50.00%) ⬆️
.../android/error/internal/DatadogExceptionHandler.kt 87.67% <ø> (ø)
...om/datadog/android/internal/utils/StrictModeExt.kt 0.00% <ø> (ø)
.../src/main/kotlin/com/datadog/android/log/Logger.kt 98.08% <ø> (-0.23%) ⬇️
...in/com/datadog/android/log/internal/LogsFeature.kt 83.45% <ø> (-1.44%) ⬇️
...dog/android/ndk/internal/NdkCrashReportsFeature.kt 69.64% <ø> (ø)
...og/android/rum/internal/anr/ANRDetectorRunnable.kt 81.82% <ø> (ø)
...internal/instrumentation/gestures/GesturesUtils.kt 78.57% <ø> (ø)
... and 10 more

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@0xnm
0xnm merged commit 68589f4 into develop Jun 6, 2025
@0xnm
0xnm deleted the nogorodnikov/move-top-level-functions-and-properties-060625 branch June 6, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambushwork ambushwork ambushwork approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@0xnm @codecov-commenter @ambushwork