Skip to content

RUM-10277: Add account information into RUM events#2706

Merged
ambushwork merged 1 commit into
feature/account-infofrom
yl/account-info/add-to-rum-events
Jun 6, 2025
Merged

RUM-10277: Add account information into RUM events#2706
ambushwork merged 1 commit into
feature/account-infofrom
yl/account-info/add-to-rum-events

Conversation

@ambushwork

@ambushwork ambushwork commented Jun 6, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

When creating RUM events, retrieve account information from context and add it.

Motivation

RUM-10277

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@codecov-commenter

codecov-commenter commented Jun 6, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 48.61111% with 37 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.93%. Comparing base (54341cd) to head (a8e351c).

Files with missing lines Patch % Lines
...id/rum/internal/domain/event/RumEventSerializer.kt 16.67% 20 Missing and 5 partials ⚠️
...g/android/rum/internal/DatadogLateCrashReporter.kt 16.67% 4 Missing and 1 partial ⚠️
.../android/rum/internal/domain/scope/RumViewScope.kt 80.00% 0 Missing and 4 partials ⚠️
...roid/rum/internal/domain/scope/RumResourceScope.kt 80.00% 0 Missing and 2 partials ⚠️
...ndroid/rum/internal/domain/scope/RumActionScope.kt 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@                   Coverage Diff                    @@
##           feature/account-info    #2706      +/-   ##
========================================================
- Coverage                 69.94%   69.93%   -0.02%     
========================================================
  Files                       824      824              
  Lines                     30743    30814      +71     
  Branches                   5172     5185      +13     
========================================================
+ Hits                      21503    21547      +44     
- Misses                     7789     7805      +16     
- Partials                   1451     1462      +11
Files with missing lines Coverage Δ
...lin/com/datadog/android/api/context/AccountInfo.kt 100.00% <100.00%> (ø)
...ore/internal/account/DatadogAccountInfoProvider.kt 80.95% <ø> (ø)
...ndroid/rum/internal/domain/scope/RumActionScope.kt 96.83% <80.00%> (-1.00%) ⬇️
...roid/rum/internal/domain/scope/RumResourceScope.kt 94.97% <80.00%> (-0.17%) ⬇️
.../android/rum/internal/domain/scope/RumViewScope.kt 94.02% <80.00%> (-0.58%) ⬇️
...g/android/rum/internal/DatadogLateCrashReporter.kt 82.61% <16.67%> (-2.78%) ⬇️
...id/rum/internal/domain/event/RumEventSerializer.kt 84.76% <16.67%> (-14.50%) ⬇️

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ambushwork
ambushwork force-pushed the yl/account-info/add-to-rum-events branch from 47ba7a3 to c460b05 Compare June 6, 2025 07:31
@ambushwork
ambushwork marked this pull request as ready for review June 6, 2025 07:54
@ambushwork
ambushwork requested review from a team as code owners June 6, 2025 07:54
@ambushwork
ambushwork force-pushed the yl/account-info/add-to-rum-events branch from c460b05 to 9393140 Compare June 6, 2025 07:59
0xnm
0xnm previously approved these changes Jun 6, 2025
View reviewed changes
@ambushwork
ambushwork dismissed stale reviews from aleksandr-gringauz and 0xnm via a8e351c June 6, 2025 11:37
@ambushwork
ambushwork force-pushed the yl/account-info/add-to-rum-events branch from 9393140 to a8e351c Compare June 6, 2025 11:37
@ambushwork
ambushwork requested a review from 0xnm June 6, 2025 11:51
@ambushwork
ambushwork merged commit 3ecfbd2 into feature/account-info Jun 6, 2025
@ambushwork
ambushwork deleted the yl/account-info/add-to-rum-events branch June 6, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes
@aleksandr-gringauz aleksandr-gringauz aleksandr-gringauz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ambushwork @codecov-commenter @0xnm @aleksandr-gringauz