Skip to content

Move LocalAttribute class and related extension methods to the internal module#2705

Merged
0xnm merged 1 commit into
developfrom
nogorodnikov/move-local-attributes-and-extension-method-to-internal-module
Jun 6, 2025
Merged

Move LocalAttribute class and related extension methods to the internal module#2705
0xnm merged 1 commit into
developfrom
nogorodnikov/move-local-attributes-and-extension-method-to-internal-module

Conversation

@0xnm

@0xnm 0xnm commented Jun 5, 2025

Copy link
Copy Markdown
Member

What does this PR do?

I noticed that we have LocalAttribute class and related extension methods in the core module and thus extension modules can be leaked into user's space.

This PR moves them to the internal module which is always used as implementation, so no leak is possible.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested review from a team as code owners June 5, 2025 16:33
@codecov-commenter

codecov-commenter commented Jun 5, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.90%. Comparing base (4912bc6) to head (8cda755).

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2705      +/-   ##
===========================================
- Coverage    69.93%   69.90%   -0.03%     
===========================================
  Files          822      822              
  Lines        30698    30639      -59     
  Branches      5175     5158      -17     
===========================================
- Hits         21467    21416      -51     
+ Misses        7782     7776       -6     
+ Partials      1449     1447       -2
Files with missing lines Coverage Δ
.../android/core/internal/logger/SdkInternalLogger.kt 93.40% <ø> (+4.72%) ⬆️
...adog/android/internal/attributes/LocalAttribute.kt 0.00% <ø> (ø)
...nternal/attributes/ViewScopeInstrumentationType.kt 0.00% <ø> (ø)
.../android/rum/internal/domain/scope/RumViewScope.kt 93.88% <ø> (ø)
...d/rum/internal/metric/ViewEndedMetricDispatcher.kt 88.24% <ø> (-2.94%) ⬇️
...droid/rum/tracking/ActivityViewTrackingStrategy.kt 90.00% <ø> (ø)
...droid/rum/tracking/FragmentViewTrackingStrategy.kt 89.86% <ø> (ø)
...oid/rum/tracking/NavigationViewTrackingStrategy.kt 86.96% <ø> (ø)
...ndroid/telemetry/internal/TelemetryEventHandler.kt 87.60% <ø> (+1.79%) ⬆️
...roid/compose/internal/ComposeNavigationObserver.kt 90.48% <ø> (ø)

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@0xnm
0xnm merged commit 60a1945 into develop Jun 6, 2025
@0xnm
0xnm deleted the nogorodnikov/move-local-attributes-and-extension-method-to-internal-module branch June 6, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@satween satween satween approved these changes
@ambushwork ambushwork ambushwork approved these changes
+1 more reviewer
@xgouchet xgouchet xgouchet approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@0xnm @codecov-commenter @xgouchet @satween @ambushwork