Skip to content

RUM-10241: Add AccountInfo into CoreFeature and DatadogContext#2702

Merged
ambushwork merged 1 commit into
feature/account-infofrom
yl/account-info/implement-core
Jun 6, 2025
Merged

RUM-10241: Add AccountInfo into CoreFeature and DatadogContext#2702
ambushwork merged 1 commit into
feature/account-infofrom
yl/account-info/implement-core

Conversation

@ambushwork

@ambushwork ambushwork commented Jun 5, 2025

Copy link
Copy Markdown
Member

What does this PR do?

Add AccountInfo into CoreFeature and DatadogContext

Motivation

RUM-10241

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@codecov-commenter

codecov-commenter commented Jun 5, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.97%. Comparing base (087b9cd) to head (4d70bbb).

Files with missing lines Patch % Lines
...n/com/datadog/android/core/internal/DatadogCore.kt 0.00% 3 Missing ⚠️
...tadog/android/core/internal/NoOpContextProvider.kt 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@                   Coverage Diff                    @@
##           feature/account-info    #2702      +/-   ##
========================================================
- Coverage                 69.98%   69.97%   -0.01%     
========================================================
  Files                       824      824              
  Lines                     30735    30743       +8     
  Branches                   5172     5172              
========================================================
+ Hits                      21509    21512       +3     
+ Misses                     7783     7781       -2     
- Partials                   1443     1450       +7
Files with missing lines Coverage Δ
.../com/datadog/android/api/context/DatadogContext.kt 100.00% <100.00%> (ø)
...n/com/datadog/android/core/internal/CoreFeature.kt 87.43% <100.00%> (+0.07%) ⬆️
...og/android/core/internal/DatadogContextProvider.kt 100.00% <100.00%> (ø)
...tadog/android/core/internal/NoOpContextProvider.kt 2.44% <0.00%> (-0.06%) ⬇️
...n/com/datadog/android/core/internal/DatadogCore.kt 81.17% <0.00%> (-1.11%) ⬇️

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ambushwork
ambushwork marked this pull request as ready for review June 5, 2025 12:12
@ambushwork
ambushwork requested review from a team as code owners June 5, 2025 12:12
@ambushwork
ambushwork force-pushed the yl/account-info/implement-core branch from 3de7713 to 4d70bbb Compare June 5, 2025 14:27
@ambushwork
ambushwork merged commit 54341cd into feature/account-info Jun 6, 2025
3 checks passed
@ambushwork
ambushwork deleted the yl/account-info/implement-core branch June 6, 2025 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aleksandr-gringauz aleksandr-gringauz aleksandr-gringauz approved these changes
+1 more reviewer
@xgouchet xgouchet xgouchet approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ambushwork @codecov-commenter @xgouchet @aleksandr-gringauz