RUM-3104 generate verification-metadata with pgp information#2698
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2698 +/- ##
===========================================
- Coverage 69.95% 69.94% -0.00%
===========================================
Files 822 822
Lines 30693 30693
Branches 5170 5170
===========================================
- Hits 21469 21468 -1
+ Misses 7775 7774 -1
- Partials 1449 1451 +2 🚀 New features to boost your workflow:
|
0xnm
reviewed
Jun 4, 2025
Comment on lines
+66
to
+67
| - aws ssm get-parameter --region us-east-1 --name ci.dd-sdk-android.signing.gpg_public_key --with-decryption --query "Parameter.Value" --out text > public_key.gpg | ||
| - export GPG_PUBLIC_FINGERPRINT=$(gpg --import --import-options show-only public_key.gpg | grep -E -o -e "[A-F0-9]{40}") |
Member
There was a problem hiding this comment.
is it possible to pipe the key directly to gpg tool without having a file beforehand?
xgouchet
force-pushed
the
xgouchet/RUM-3104/add_pgp_verification
branch
2 times, most recently
from
June 5, 2025 07:03
fbea6da to
6afcac9
Compare
0xnm
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the PGP information to the
verification-metadata.xmlgenerated file.