RUM-10242: Add AccountInfo data class and provider#2696
Merged
Conversation
ambushwork
force-pushed
the
yl/account-info/add-entity
branch
from
June 4, 2025 08:15
6302757 to
ea9e851
Compare
ambushwork
changed the title
ambushwork
force-pushed
the
yl/account-info/add-entity
branch
from
June 4, 2025 09:22
ea9e851 to
4bf0ee4
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/account-info #2696 +/- ##
========================================================
- Coverage 69.96% 69.90% -0.05%
========================================================
Files 822 824 +2
Lines 30711 30735 +24
Branches 5170 5172 +2
========================================================
Hits 21484 21484
- Misses 7786 7792 +6
- Partials 1441 1459 +18
🚀 New features to boost your workflow:
|
ambushwork
marked this pull request as ready for review
June 4, 2025 10:00
aleksandr-gringauz
previously approved these changes
Jun 4, 2025
Contributor
could you please explain what exactly will be removed? |
ambushwork
force-pushed
the
yl/account-info/add-entity
branch
from
June 4, 2025 11:37
4bf0ee4 to
4dfa69d
Compare
Member
Author
@aleksandr-gringauz here is the explanation from Xavier:
|
aleksandr-gringauz
approved these changes
Jun 4, 2025
0xnm
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
AccountInfodata classDatadogAccountInfoProviderandMutableAccountInfoProviderNotice: We don't add serialiser and deserialiser for
AccountInfoasUserInfobecause we don't need to persist it for crash report since it will be removed in V3 soon.Motivation
RUM-10242
Review checklist (to be filled by reviewers)