Skip to content

RUM-10240: Add public APIs for set account information#2694

Merged
ambushwork merged 1 commit into
feature/account-infofrom
yl/add-account-info-api
Jun 4, 2025
Merged

RUM-10240: Add public APIs for set account information#2694
ambushwork merged 1 commit into
feature/account-infofrom
yl/add-account-info-api

Conversation

@ambushwork

Copy link
Copy Markdown
Member

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@ambushwork
ambushwork force-pushed the yl/add-account-info-api branch from 12dfb75 to 8d4e69c Compare June 3, 2025 09:44
@codecov-commenter

codecov-commenter commented Jun 3, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 33.33333% with 12 lines in your changes missing coverage. Please review.

Project coverage is 69.89%. Comparing base (9d00117) to head (7eb66d8).

Files with missing lines Patch % Lines
...ore/src/main/kotlin/com/datadog/android/Datadog.kt 50.00% 6 Missing ⚠️
...src/main/kotlin/com/datadog/android/api/SdkCore.kt 0.00% 3 Missing ⚠️
...tadog/android/core/internal/NoOpInternalSdkCore.kt 0.00% 3 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                    @@
##           feature/account-info    #2694      +/-   ##
========================================================
- Coverage                 70.07%   69.89%   -0.18%     
========================================================
  Files                       822      822              
  Lines                     30693    30711      +18     
  Branches                   5170     5170              
========================================================
- Hits                      21508    21464      -44     
- Misses                     7755     7787      +32     
- Partials                   1430     1460      +30     
Files with missing lines Coverage Δ
...n/com/datadog/android/core/internal/DatadogCore.kt 82.27% <ø> (ø)
...src/main/kotlin/com/datadog/android/api/SdkCore.kt 14.29% <0.00%> (-10.71%) ⬇️
...tadog/android/core/internal/NoOpInternalSdkCore.kt 8.54% <0.00%> (-0.32%) ⬇️
...ore/src/main/kotlin/com/datadog/android/Datadog.kt 69.07% <50.00%> (-2.69%) ⬇️

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ambushwork
ambushwork marked this pull request as ready for review June 3, 2025 10:30
@ambushwork
ambushwork requested review from a team as code owners June 3, 2025 10:30
Comment thread dd-sdk-android-core/src/main/kotlin/com/datadog/android/Datadog.kt
Comment thread dd-sdk-android-core/src/main/kotlin/com/datadog/android/Datadog.kt Outdated
@ambushwork
ambushwork force-pushed the yl/add-account-info-api branch from 8d4e69c to 7eb66d8 Compare June 3, 2025 15:06
Comment thread dd-sdk-android-core/src/main/kotlin/com/datadog/android/Datadog.kt
@ambushwork
ambushwork merged commit 072d162 into feature/account-info Jun 4, 2025
@ambushwork
ambushwork deleted the yl/add-account-info-api branch June 4, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants