Enhancement of Compose Actions tracking reflection#2692
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2692 +/- ##
===========================================
+ Coverage 69.91% 69.92% +0.02%
===========================================
Files 822 822
Lines 30693 30693
Branches 5169 5170 +1
===========================================
+ Hits 21456 21462 +6
+ Misses 7794 7783 -11
- Partials 1443 1448 +5
🚀 New features to boost your workflow:
|
ambushwork
marked this pull request as ready for review
June 2, 2025 13:36
0xnm
approved these changes
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR enhances compose actions tracking reflection on two points:
SelectableElementmodifier, we treat it also as a clickable target, in this case when user taps on the selectable item, a RUM tap action will be sent as well.roleof the element, before if it fails, the whole action tracking will abort, with this PR, therolewill return null, and action tracking continues.Review checklist (to be filled by reviewers)