Fix proguard rules for Method Called Metrics#2691
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2691 +/- ##
===========================================
+ Coverage 69.89% 69.96% +0.06%
===========================================
Files 822 822
Lines 30692 30692
Branches 5169 5169
===========================================
+ Hits 21452 21471 +19
+ Misses 7793 7769 -24
- Partials 1447 1452 +5 🚀 New features to boost your workflow:
|
ambushwork
marked this pull request as ready for review
June 2, 2025 09:37
0xnm
approved these changes
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We have "Method Called" Metrics in both RUM
DatadogRumMonitorclass and Session ReplayTreeViewTraversalclass,their class name will be assigned as the attribute of "caller_class". However they can be obfuscated in release build, so we need to put them in the "consumer-rules.pro" file to keep the class name.
Review checklist (to be filled by reviewers)