Skip to content

Add Method Called Metric on Rum event handling#2687

Merged
ambushwork merged 1 commit into
developfrom
yl/add-method-called-on-rum-event-processing
May 31, 2025
Merged

Add Method Called Metric on Rum event handling#2687
ambushwork merged 1 commit into
developfrom
yl/add-method-called-on-rum-event-processing

Conversation

@ambushwork

Copy link
Copy Markdown
Member

What does this PR do?

As discussed in the android dev chat, we should add "Method Called" Metrics on Rum event handling to collect the execution time of Rum event handling by type.

Motivation

Provide more information for investigation the backpressued issue.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@ambushwork
ambushwork force-pushed the yl/add-method-called-on-rum-event-processing branch 2 times, most recently from b5e1c2a to 92beb8c Compare May 30, 2025 12:35
@codecov-commenter

codecov-commenter commented May 30, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 69.94%. Comparing base (0933d54) to head (20de9dc).
⚠️ Report is 2060 commits behind head on develop.

Files with missing lines Patch % Lines
.../android/rum/internal/monitor/DatadogRumMonitor.kt 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2687   +/-   ##
========================================
  Coverage    69.94%   69.94%           
========================================
  Files          822      822           
  Lines        30687    30692    +5     
  Branches      5168     5169    +1     
========================================
+ Hits         21462    21467    +5     
- Misses        7774     7782    +8     
+ Partials      1451     1443    -8     
Files with missing lines Coverage Δ
.../android/rum/internal/monitor/DatadogRumMonitor.kt 85.37% <83.33%> (-0.39%) ⬇️

... and 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

xgouchet
xgouchet previously approved these changes May 30, 2025
@ambushwork
ambushwork marked this pull request as ready for review May 30, 2025 13:14
@ambushwork
ambushwork requested review from a team as code owners May 30, 2025 13:14
@ambushwork
ambushwork force-pushed the yl/add-method-called-on-rum-event-processing branch from 92beb8c to 20de9dc Compare May 30, 2025 13:33
@ambushwork
ambushwork requested a review from xgouchet May 30, 2025 13:55
@ambushwork
ambushwork merged commit 7f6ef9e into develop May 31, 2025
@ambushwork
ambushwork deleted the yl/add-method-called-on-rum-event-processing branch May 31, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants