RUM-10173: Change Benchmark artifact Id to dd-sdk-android-benchmark#2686
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2686 +/- ##
===========================================
+ Coverage 69.94% 69.94% +0.01%
===========================================
Files 820 820
Lines 30657 30657
Branches 5162 5162
===========================================
+ Hits 21441 21443 +2
- Misses 7769 7776 +7
+ Partials 1447 1438 -9 🚀 New features to boost your workflow:
|
ambushwork
marked this pull request as ready for review
May 30, 2025 08:58
0xnm
previously approved these changes
May 30, 2025
| publishingConfig("An internal benchmarking tool to measure the overhead of Datadog SDK") | ||
| publishingConfig( | ||
| projectDescription = "An internal benchmarking tool to measure the overhead of Datadog SDK", | ||
| customArtifactId = "dd-sdk-android-benchmark" |
Member
There was a problem hiding this comment.
maybe call it dd-sdk-android-benchmark-internal to highlight that it is for the internal use only?
Contributor
|
@sbarrio jfyi |
ambushwork
force-pushed
the
yl/update-benchmark-artifact-name
branch
from
May 30, 2025 11:11
1c040fc to
ccd7932
Compare
aleksandr-gringauz
approved these changes
May 30, 2025
0xnm
approved these changes
May 30, 2025
Contributor
Thanks!, I'll modify the import on the RN sdk. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Change Benchmark artifact Id to dd-sdk-android-benchmark
Motivation
RUM-10173
Review checklist (to be filled by reviewers)