Skip to content

RUM-9923 Custom endpoint URL are taken as is#2685

Merged
xgouchet merged 1 commit into
feature/v3from
xgouchet/RUM-9923/custom_endpoint
May 30, 2025
Merged

RUM-9923 Custom endpoint URL are taken as is#2685
xgouchet merged 1 commit into
feature/v3from
xgouchet/RUM-9923/custom_endpoint

Conversation

@xgouchet

Copy link
Copy Markdown
Contributor

What does this PR do?

Align setting custom endpoint URL behavior with other platforms

Motivation

Originally, on Android, we would only set the host, expecting the custom endpoint to have a path matching our own intake path (usually in the form {host}/api/v2/{track}.

We now aim to have the same behaviour across platforms, so we take the provided url as is.

@xgouchet
xgouchet requested review from a team as code owners May 30, 2025 06:36
@xgouchet
xgouchet force-pushed the xgouchet/RUM-9923/custom_endpoint branch from 0d1898a to 81250d4 Compare May 30, 2025 07:02
@codecov-commenter

codecov-commenter commented May 30, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.86%. Comparing base (41537e0) to head (0910168).
⚠️ Report is 534 commits behind head on feature/v3.

Additional details and impacted files
@@              Coverage Diff               @@
##           feature/v3    #2685      +/-   ##
==============================================
+ Coverage       67.86%   67.86%   +0.01%     
==============================================
  Files             821      821              
  Lines           30544    30525      -19     
  Branches         5159     5158       -1     
==============================================
- Hits            20726    20715      -11     
+ Misses           8454     8447       -7     
+ Partials         1364     1363       -1     
Files with missing lines Coverage Δ
...otlin/com/datadog/android/log/LogsConfiguration.kt 100.00% <ø> (ø)
...dog/android/log/internal/net/LogsRequestFactory.kt 100.00% <100.00%> (ø)
...kotlin/com/datadog/android/rum/RumConfiguration.kt 97.30% <ø> (ø)
...adog/android/rum/internal/net/RumRequestFactory.kt 67.07% <100.00%> (+0.41%) ⬆️
...ndroid/sessionreplay/SessionReplayConfiguration.kt 96.47% <ø> (-0.30%) ⬇️
...sionreplay/internal/net/ResourcesRequestFactory.kt 68.89% <100.00%> (-2.54%) ⬇️
...essionreplay/internal/net/SegmentRequestFactory.kt 100.00% <100.00%> (ø)
...in/com/datadog/android/trace/TraceConfiguration.kt 100.00% <ø> (ø)
...android/trace/internal/net/TracesRequestFactory.kt 100.00% <100.00%> (ø)

... and 26 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xgouchet
xgouchet merged commit b105196 into feature/v3 May 30, 2025
@xgouchet
xgouchet deleted the xgouchet/RUM-9923/custom_endpoint branch May 30, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants