RUM-9501 Don't send fatal errors to Logs, only send them to RUM#2675
Merged
Conversation
xgouchet
force-pushed
the
xgouchet/RUM-9501/remove_error_logs
branch
from
May 28, 2025 09:27
d98f235 to
7741623
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature/v3 #2675 +/- ##
==============================================
- Coverage 67.86% 67.55% -0.30%
==============================================
Files 821 814 -7
Lines 30544 30253 -291
Branches 5159 5135 -24
==============================================
- Hits 20726 20437 -289
- Misses 8454 8455 +1
+ Partials 1364 1361 -3
🚀 New features to boost your workflow:
|
Member
|
PR LGTM, but I am curious what's the motivation behind this one? (I don't see it neither in the description nor in the ticket) |
ambushwork
previously approved these changes
May 30, 2025
Member
I see it in V3 scope doc, OK for me |
0xnm
requested changes
May 30, 2025
| @@ -44,9 +43,6 @@ internal class DatadogNdkCrashHandler( | |||
| internal var lastNetworkInfo: NetworkInfo? = null | |||
Member
There was a problem hiding this comment.
Probably we can remove lastNetworkInfo and lastUserInfo since they were used only for Logs? We can also remove the part where we write them to the disk.
Comment on lines
-298
to
-300
| val logsFeature = sdkCore.getFeature(Feature.LOGS_FEATURE_NAME) | ||
| if (logsFeature != null) { | ||
| logsFeature.sendEvent( |
Member
There was a problem hiding this comment.
we also need to remove related code in the LogsFeature
0xnm
previously approved these changes
May 30, 2025
xgouchet
force-pushed
the
xgouchet/RUM-9501/remove_error_logs
branch
from
May 30, 2025 12:48
2dce78b to
ba29caf
Compare
0xnm
approved these changes
May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
let the crash handlers (
DatadogExceptionHandlerandDatadogNdkCrashHandler) only send errors to RUM