RUM-9514 remove deprecated userInfo methods#2672
Merged
Merged
Conversation
0xnm
previously approved these changes
May 26, 2025
| fun `M keep existing properties W addUserProperties() is called`( | ||
| @Forgery userInfo: UserInfo, | ||
| @StringForgery userId: String, | ||
| @StringForgery forge: Forge |
Member
There was a problem hiding this comment.
minor: strange that there is a StringForgery annotation here, it shouldn't have any effect and can be removed.
xgouchet
force-pushed
the
xgouchet/RUM-9514/remove_deprecated
branch
from
May 26, 2025 15:25
ad4e0f8 to
cc5cb93
Compare
0xnm
previously approved these changes
May 26, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/v3 #2672 +/- ##
==============================================
- Coverage 67.85% 67.79% -0.06%
==============================================
Files 821 821
Lines 30570 30563 -7
Branches 5160 5160
==============================================
- Hits 20743 20720 -23
- Misses 8458 8475 +17
+ Partials 1369 1368 -1
🚀 New features to boost your workflow:
|
xgouchet
force-pushed
the
xgouchet/RUM-9514/remove_deprecated
branch
from
May 27, 2025 08:41
cc5cb93 to
f41b80d
Compare
0xnm
approved these changes
May 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove the option to set a null userId