RUM-10120: Better project-type dependency resolution for Detekt custom rules execution#2670
Merged
0xnm merged 1 commit intoMay 27, 2025
Conversation
0xnm
marked this pull request as ready for review
May 23, 2025 15:47
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2670 +/- ##
===========================================
+ Coverage 69.95% 69.96% +0.01%
===========================================
Files 820 820
Lines 30657 30657
Branches 5162 5162
===========================================
+ Hits 21445 21448 +3
- Misses 7769 7773 +4
+ Partials 1443 1436 -7 🚀 New features to boost your workflow:
|
satween
approved these changes
May 26, 2025
Contributor
There was a problem hiding this comment.
Looks good to me, although it would be great to have some linked JIRA ticket with more details ( like warnings examples) in case of any troubles in a future.
Also we probably need to add some information somewhere that when new module is being added developer should revise DetectCostomConfig.kt file and check if he need to adjust logic that adds dependencies. Such internal changes is not frequent but on the other hand it's tricky to find it
0xnm
changed the title
Member
Author
|
@satween I linked a Jira ticket. Not sure where info about new module setup should be added. |
0xnm
deleted the
nogorodnikov/better-projects-dependency-resolution-for-detekt
branch
May 27, 2025 08:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I noticed that during custom Detekt rules job execution there were some warnings regarding the types that cannot be resolved.
This PR removes (mostly) the need to specify project dependencies for Detekt run, although there is a pitfall:
apiconfiguration cannot be resolved, so we cannot know transitive project dependencies. Maybe this can be solved with detached configuration, but for now let's just specify most common modules:dd-sdk-android-coreand:dd-sdk-android-internalby default for everything.Review checklist (to be filled by reviewers)