Skip to content

Minor cleanup#2669

Merged
0xnm merged 1 commit into
nogorodnikov/rum-8170/feature-context-syncfrom
nogorodnikov/minor-cleanup-230525
May 23, 2025
Merged

Minor cleanup#2669
0xnm merged 1 commit into
nogorodnikov/rum-8170/feature-context-syncfrom
nogorodnikov/minor-cleanup-230525

Conversation

@0xnm

@0xnm 0xnm commented May 23, 2025

Copy link
Copy Markdown
Member

What does this PR do?

Just a minor cleanup mainly in the Session Replay module.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested review from a team as code owners May 23, 2025 13:35
@codecov-commenter

codecov-commenter commented May 23, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 70.10%. Comparing base (818bc3c) to head (7d65ca5).
⚠️ Report is 160 commits behind head on nogorodnikov/rum-8170/feature-context-sync.

Files with missing lines Patch % Lines
...com/datadog/android/sessionreplay/SessionReplay.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@                              Coverage Diff                               @@
##           nogorodnikov/rum-8170/feature-context-sync    #2669      +/-   ##
==============================================================================
+ Coverage                                       70.09%   70.10%   +0.01%     
==============================================================================
  Files                                             819      816       -3     
  Lines                                           30619    30603      -16     
  Branches                                         5122     5120       -2     
==============================================================================
- Hits                                            21460    21452       -8     
+ Misses                                           7737     7724      -13     
- Partials                                         1422     1427       +5
Files with missing lines Coverage Δ
...android/sessionreplay/internal/ResourcesFeature.kt 88.89% <100.00%> (ø)
...oid/sessionreplay/internal/SessionReplayFeature.kt 98.84% <100.00%> (ø)
...sionreplay/internal/SessionReplayRecordCallback.kt 100.00% <100.00%> (ø)
...lay/internal/resources/ResourceDataStoreManager.kt 94.23% <100.00%> (ø)
...play/internal/storage/SessionReplayRecordWriter.kt 100.00% <100.00%> (ø)
...y/internal/storage/SessionReplayResourcesWriter.kt 85.71% <100.00%> (ø)
...com/datadog/android/sessionreplay/SessionReplay.kt 73.68% <0.00%> (+0.96%) ⬆️

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@0xnm
0xnm merged commit 80a430e into nogorodnikov/rum-8170/feature-context-sync May 23, 2025
@0xnm
0xnm deleted the nogorodnikov/minor-cleanup-230525 branch May 23, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambushwork ambushwork ambushwork approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@0xnm @codecov-commenter @ambushwork