RUM-10088: Propagate has_replay flag to RumContext object#2668
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## nogorodnikov/rum-8170/feature-context-sync #2668 +/- ##
==============================================================================
- Coverage 70.08% 70.03% -0.06%
==============================================================================
Files 819 819
Lines 30620 30619 -1
Branches 5119 5122 +3
==============================================================================
- Hits 21460 21442 -18
- Misses 7741 7745 +4
- Partials 1419 1432 +13
🚀 New features to boost your workflow:
|
ambushwork
approved these changes
May 22, 2025
0xnm
deleted the
nogorodnikov/rum-10088/propagate-has_replay-flag-to-RumContext
branch
May 22, 2025 15:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR correctly sets
has_replayflag from the Session Replay context in theRumContextobject which is returned by theRumScope.getRumContext. It wasn't set before.Review checklist (to be filled by reviewers)