RUM-9345: Use reflection to retrieve semantics information in modifier#2667
Merged
Conversation
ambushwork
force-pushed
the
yl/fix-action-tracking-crash
branch
from
May 22, 2025 09:07
f47f937 to
c4d73c0
Compare
ambushwork
marked this pull request as ready for review
May 22, 2025 09:37
0xnm
previously approved these changes
May 22, 2025
ambushwork
force-pushed
the
yl/fix-action-tracking-crash
branch
from
May 22, 2025 12:12
c4d73c0 to
67f98bf
Compare
0xnm
previously approved these changes
May 22, 2025
ambushwork
force-pushed
the
yl/fix-action-tracking-crash
branch
from
May 22, 2025 12:28
67f98bf to
d88757b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2667 +/- ##
===========================================
- Coverage 69.97% 69.94% -0.03%
===========================================
Files 820 820
Lines 30637 30657 +20
Branches 5156 5162 +6
===========================================
+ Hits 21437 21441 +4
- Misses 7764 7775 +11
- Partials 1436 1441 +5
🚀 New features to boost your workflow:
|
0xnm
approved these changes
May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Using internal field
collapsedSemanticsofLayoutNodemay not work in all the build types, so this PR replaces it with classic reflection to retrieve the additional semantics information for the node.Also fix the catch
Throwableinstead ofException.Motivation
RUM-9345
Review checklist (to be filled by reviewers)