RUM-9973: Remove addFirst, removeFirst, removeLast usages#2664
Merged
0xnm merged 1 commit intoMay 21, 2025
Merged
Conversation
ambushwork
previously approved these changes
May 20, 2025
0xnm
force-pushed
the
nogorodnikov/rum-9973/replace-addfirst-removefirst-usages
branch
from
May 20, 2025 13:23
dae0f65 to
7af55f5
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2664 +/- ##
========================================
Coverage 69.95% 69.95%
========================================
Files 820 820
Lines 30636 30637 +1
Branches 5155 5156 +1
========================================
+ Hits 21429 21431 +2
+ Misses 7769 7764 -5
- Partials 1438 1442 +4
🚀 New features to boost your workflow:
|
aleksandr-gringauz
approved these changes
May 21, 2025
jonathanmos
approved these changes
May 21, 2025
0xnm
deleted the
nogorodnikov/rum-9973/replace-addfirst-removefirst-usages
branch
May 21, 2025 07:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes
addFirst,removeFirst,removeLastusages, since they can cause runtime errors if app is built with Android API 35 but with old build tooling like AGP 7.x instead of AGP 8.6.x, old desugaring version.Review checklist (to be filled by reviewers)