Skip to content

Fix flaky DatadogRumMonitor tests#2663

Merged
0xnm merged 1 commit into
nogorodnikov/rum-8170/feature-context-syncfrom
nogorodnikov/fix-flaky-datadogrummonitor-tests-200525
May 21, 2025
Merged

Fix flaky DatadogRumMonitor tests#2663
0xnm merged 1 commit into
nogorodnikov/rum-8170/feature-context-syncfrom
nogorodnikov/fix-flaky-datadogrummonitor-tests-200525

Conversation

@0xnm

@0xnm 0xnm commented May 20, 2025

Copy link
Copy Markdown
Member

What does this PR do?

Tests for DatadogRumMonitor were flaky because of the missing setup.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested review from a team as code owners May 20, 2025 12:30
@codecov-commenter

codecov-commenter commented May 20, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.07%. Comparing base (a3206f3) to head (23f612a).
⚠️ Report is 186 commits behind head on nogorodnikov/rum-8170/feature-context-sync.

Additional details and impacted files
@@                              Coverage Diff                               @@
##           nogorodnikov/rum-8170/feature-context-sync    #2663      +/-   ##
==============================================================================
- Coverage                                       70.09%   70.07%   -0.02%     
==============================================================================
  Files                                             819      819              
  Lines                                           30615    30601      -14     
  Branches                                         5111     5107       -4     
==============================================================================
- Hits                                            21458    21441      -17     
+ Misses                                           7742     7741       -1     
- Partials                                         1415     1419       +4     

see 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@0xnm
0xnm merged commit 7d7392e into nogorodnikov/rum-8170/feature-context-sync May 21, 2025
@0xnm
0xnm deleted the nogorodnikov/fix-flaky-datadogrummonitor-tests-200525 branch May 21, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants