RUM-9345: Add Compose custom attributes for actions tracking#2661
Merged
Conversation
ambushwork
force-pushed
the
yl/actions-view-tracking-enrichment
branch
2 times, most recently
from
May 20, 2025 09:32
0a7a014 to
36f0888
Compare
ambushwork
marked this pull request as ready for review
May 20, 2025 09:36
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #2661 +/- ##
===========================================
+ Coverage 69.95% 69.95% +0.01%
===========================================
Files 820 820
Lines 30636 30650 +14
Branches 5155 5158 +3
===========================================
+ Hits 21429 21441 +12
- Misses 7769 7770 +1
- Partials 1438 1439 +1
🚀 New features to boost your workflow:
|
0xnm
previously approved these changes
May 20, 2025
Comment on lines
+220
to
+228
| /** | ||
| * The touch target selection state if it is selectable. | ||
| * This is only available for Jetpack Compose components | ||
| */ | ||
| const val ACTION_TARGET_SELECTED: String = "action.target.selected" | ||
|
|
||
| /** | ||
| * The touch target semantics role if it is available. | ||
| * This is only available for Jetpack Compose components |
Member
There was a problem hiding this comment.
Suggested change
| /** | |
| * The touch target selection state if it is selectable. | |
| * This is only available for Jetpack Compose components | |
| */ | |
| const val ACTION_TARGET_SELECTED: String = "action.target.selected" | |
| /** | |
| * The touch target semantics role if it is available. | |
| * This is only available for Jetpack Compose components | |
| /** | |
| * The touch target selection state if it is selectable. | |
| * This is only available for Jetpack Compose components. | |
| */ | |
| const val ACTION_TARGET_SELECTED: String = "action.target.selected" | |
| /** | |
| * The touch target semantics role if it is available. | |
| * This is only available for Jetpack Compose components. |
| ACTION_TARGET_SELECTED to selected, | ||
| ACTION_TARGET_ROLE to role | ||
| ) | ||
| } ?: mapOf() |
Member
There was a problem hiding this comment.
Suggested change
| } ?: mapOf() | |
| }.orEmpty() |
| * @property name the name of the target node. | ||
| * @property customAttributes the custom attributes that the target node may have. | ||
| */ | ||
| data class Node( |
Member
There was a problem hiding this comment.
probably to annotate with @InternalApi?
ambushwork
force-pushed
the
yl/actions-view-tracking-enrichment
branch
from
May 20, 2025 14:48
36f0888 to
3645230
Compare
0xnm
approved these changes
May 21, 2025
jonathanmos
approved these changes
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In this PR, we try to provide as much as possible about the action target information in Jetpack Compose actions tracking.
Two attributes is added for compose semantics node:
Motivation
RUM-9345
Additional note
Also enable compose auto-instrumentation for sample app
Review checklist (to be filled by reviewers)