RUM-9908 Create view attributes update methods#2655
Merged
xgouchet merged 2 commits intoMay 23, 2025
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature/v3 #2655 +/- ##
==============================================
+ Coverage 67.84% 67.85% +0.01%
==============================================
Files 821 821
Lines 30555 30570 +15
Branches 5158 5160 +2
==============================================
+ Hits 20729 20741 +12
- Misses 8454 8472 +18
+ Partials 1372 1357 -15
🚀 New features to boost your workflow:
|
xgouchet
force-pushed
the
xgouchet/RUM-9908/align_attribute_propagation
branch
from
May 16, 2025 10:11
fb654a1 to
872dfe4
Compare
mariusc83
reviewed
May 16, 2025
| eventTime: Time, | ||
| writer: DataWriter<Any> | ||
| ) { | ||
| attributes.putAll(GlobalRumMonitor.get(sdkCore).getAttributes()) |
Member
There was a problem hiding this comment.
I think this PR contains the changes from the other one ? I think you need a rebase here ?
xgouchet
force-pushed
the
xgouchet/RUM-9908/add_view_attributes_update_methods
branch
from
May 19, 2025 09:06
a5dcf59 to
ae7afba
Compare
xgouchet
force-pushed
the
xgouchet/RUM-9908/add_view_attributes_update_methods
branch
from
May 19, 2025 09:22
ae7afba to
18f2194
Compare
ambushwork
previously approved these changes
May 19, 2025
xgouchet
force-pushed
the
xgouchet/RUM-9908/align_attribute_propagation
branch
4 times, most recently
from
May 20, 2025 06:58
370a88b to
11b287e
Compare
xgouchet
force-pushed
the
xgouchet/RUM-9908/add_view_attributes_update_methods
branch
from
May 20, 2025 08:11
18f2194 to
9ced598
Compare
mariusc83
previously approved these changes
May 20, 2025
Base automatically changed from
xgouchet/RUM-9908/align_attribute_propagation
to
feature/v3
May 20, 2025 09:00
xgouchet
dismissed stale reviews from mariusc83 and ambushwork
May 20, 2025 09:00
The base branch was changed.
| fun clearAttributes() | ||
| fun stopSession() | ||
| fun addViewLoadingTime(Boolean) | ||
| fun addViewAttributes(Map<String, Any?>) |
There was a problem hiding this comment.
question/ Any reason for not having an interface for single attributes?
Additionally, is it planned an interface to add multiple global attributes?
Contributor
Author
There was a problem hiding this comment.
The RFC didn't mention adding a single attribute although it's feasible anyway with the current API.
I can create another PR which adds the option to add multiple global attributes 👍
xgouchet
force-pushed
the
xgouchet/RUM-9908/add_view_attributes_update_methods
branch
from
May 21, 2025 07:45
9ced598 to
db5fc6f
Compare
xgouchet
force-pushed
the
xgouchet/RUM-9908/add_view_attributes_update_methods
branch
from
May 22, 2025 16:17
db5fc6f to
a4a2645
Compare
mariusc83
approved these changes
May 23, 2025
ambushwork
approved these changes
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add methods for customer to update the current View's attributes