Skip to content

RUM-9908 Align attribute propagation mechanism#2654

Merged
xgouchet merged 6 commits into
feature/v3from
xgouchet/RUM-9908/align_attribute_propagation
May 20, 2025
Merged

RUM-9908 Align attribute propagation mechanism#2654
xgouchet merged 6 commits into
feature/v3from
xgouchet/RUM-9908/align_attribute_propagation

Conversation

@xgouchet

@xgouchet xgouchet commented May 16, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

The goal is to align how custom attributes are propagated through RUM events :

  • Global attributes are propagated to all events
  • View level attributes are propagated downwards (as long as the view is active), overwriting global attributes
  • Event level attributes overwrite view and global attributes

Motivation

Bring more consistency between platforms

@xgouchet
xgouchet requested review from a team as code owners May 16, 2025 06:23
@codecov-commenter

codecov-commenter commented May 16, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.66%. Comparing base (67598c9) to head (11b287e).
⚠️ Report is 552 commits behind head on feature/v3.

Files with missing lines Patch % Lines
...roid/rum/internal/domain/scope/RumResourceScope.kt 88.24% 0 Missing and 2 partials ⚠️
...d/rum/internal/domain/scope/RumApplicationScope.kt 50.00% 1 Missing ⚠️
...adog/android/rum/internal/domain/scope/RumScope.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@              Coverage Diff               @@
##           feature/v3    #2654      +/-   ##
==============================================
- Coverage       67.77%   67.66%   -0.11%     
==============================================
  Files             821      821              
  Lines           30605    30600       -5     
  Branches         5158     5158              
==============================================
- Hits            20742    20705      -37     
- Misses           8502     8531      +29     
- Partials         1361     1364       +3
Files with missing lines Coverage Δ
...ndroid/rum/internal/domain/scope/RumActionScope.kt 97.80% <100.00%> (-0.02%) ⬇️
...droid/rum/internal/domain/scope/RumSessionScope.kt 96.72% <100.00%> (ø)
...d/rum/internal/domain/scope/RumViewManagerScope.kt 91.41% <100.00%> (-0.51%) ⬇️
.../android/rum/internal/domain/scope/RumViewScope.kt 94.83% <100.00%> (+0.95%) ⬆️
...d/rum/internal/domain/scope/RumApplicationScope.kt 94.29% <50.00%> (-0.86%) ⬇️
...adog/android/rum/internal/domain/scope/RumScope.kt 50.00% <0.00%> (-50.00%) ⬇️
...roid/rum/internal/domain/scope/RumResourceScope.kt 95.07% <88.24%> (-0.42%) ⬇️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

0xnm
0xnm previously approved these changes May 16, 2025
View reviewed changes
Comment thread ...dk-android-rum/src/main/kotlin/com/datadog/android/rum/internal/domain/scope/RumViewScope.kt Outdated
Comment thread ...com/datadog/android/rum/internal/domain/scope/RumApplicationScopeAttributePropagationTest.kt Outdated
@xgouchet
xgouchet force-pushed the xgouchet/RUM-9908/align_attribute_propagation branch from fb654a1 to 872dfe4 Compare May 16, 2025 10:11
@xgouchet
xgouchet requested a review from 0xnm May 16, 2025 10:16
@xgouchet
xgouchet requested a review from mariusc83 May 16, 2025 16:33
0xnm
0xnm previously approved these changes May 19, 2025
View reviewed changes
@xgouchet
xgouchet force-pushed the xgouchet/RUM-9908/align_attribute_propagation branch from 22d36a1 to 0c9e49f Compare May 19, 2025 13:16
0xnm
0xnm previously approved these changes May 19, 2025
View reviewed changes
@xgouchet
xgouchet force-pushed the xgouchet/RUM-9908/align_attribute_propagation branch from 0c9e49f to 3d4acee Compare May 19, 2025 16:37
@xgouchet
xgouchet force-pushed the xgouchet/RUM-9908/align_attribute_propagation branch from 28d714e to 370a88b Compare May 19, 2025 20:49
@xgouchet
xgouchet requested a review from 0xnm May 19, 2025 20:49
@xgouchet
xgouchet force-pushed the xgouchet/RUM-9908/align_attribute_propagation branch from 370a88b to 11b287e Compare May 20, 2025 06:58
mariusc83
mariusc83 approved these changes May 20, 2025
View reviewed changes

@mariusc83 mariusc83 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xgouchet
xgouchet merged commit 887fd1d into feature/v3 May 20, 2025
@xgouchet
xgouchet deleted the xgouchet/RUM-9908/align_attribute_propagation branch May 20, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mariusc83 mariusc83 mariusc83 approved these changes
@0xnm 0xnm Awaiting requested review from 0xnm

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xgouchet @codecov-commenter @mariusc83 @0xnm