RUM-7855 Remove telemetry target from error logging in PlainBatchFileReaderWriter#2653
Merged
mariusc83 merged 1 commit intoMay 15, 2025
Conversation
0xnm
previously approved these changes
May 15, 2025
mariusc83
force-pushed
the
mconstantin/rum-7855/investigate-failedtowrite-error
branch
from
May 15, 2025 13:00
c778065 to
8e010de
Compare
0xnm
approved these changes
May 15, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2653 +/- ##
===========================================
+ Coverage 70.06% 70.09% +0.03%
===========================================
Files 820 820
Lines 30598 30598
Branches 5136 5136
===========================================
+ Hits 21436 21446 +10
+ Misses 7733 7720 -13
- Partials 1429 1432 +3
🚀 New features to boost your workflow:
|
mariusc83
deleted the
mconstantin/rum-7855/investigate-failedtowrite-error
branch
May 15, 2025 14:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This pull request makes a minor change to the
PlainBatchFileReaderWriterclass in thedd-sdk-android-coremodule. It removes theInternalLogger.Target.TELEMETRYtarget from the list of logging targets when anIOExceptionoccurs.dd-sdk-android-core/src/main/kotlin/com/datadog/android/core/internal/persistence/file/batch/PlainBatchFileReaderWriter.kt: Updated the logging configuration to excludeInternalLogger.Target.TELEMETRYfrom the error logging targets.…ReaderWriterThis error is not actionable as it's caused by lack of space on the user device.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)