Skip to content

Fix logging format for error messages in PlainBatchFileReaderWriter#2652

Merged
dd-mergequeue[bot] merged 1 commit into
developfrom
mconstantin/fix-error-log-message
May 15, 2025
Merged

Fix logging format for error messages in PlainBatchFileReaderWriter#2652
dd-mergequeue[bot] merged 1 commit into
developfrom
mconstantin/fix-error-log-message

Conversation

@mariusc83

@mariusc83 mariusc83 commented May 15, 2025

Copy link
Copy Markdown
Member

This pull request includes a minor change to the PlainBatchFileReaderWriter class in the dd-sdk-android-core module. The change fixes the logging statement by replacing a string literal with the constant ERROR_READ for improved code clarity and maintainability.

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@mariusc83
mariusc83 requested review from a team as code owners May 15, 2025 12:21
@mariusc83
mariusc83 force-pushed the mconstantin/fix-error-log-message branch from 47948f4 to 9206327 Compare May 15, 2025 12:34
@mariusc83

mariusc83 commented May 15, 2025

Copy link
Copy Markdown
Member Author

/merge -p medium

@dd-devflow

dd-devflow Bot commented May 15, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-05-15 12:52:49 UTC ℹ️ Start processing command /merge -p medium

2025-05-15 12:52:55 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-05-15 13:26:14 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in develop is approximately 0s (p90).

2025-05-15 14:14:19 UTC ℹ️ MergeQueue: This merge request was merged

@codecov-commenter

codecov-commenter commented May 15, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 69.97%. Comparing base (b84746f) to head (9206327).
⚠️ Report is 2086 commits behind head on develop.

Files with missing lines Patch % Lines
...rsistence/file/batch/PlainBatchFileReaderWriter.kt 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2652      +/-   ##
===========================================
- Coverage    69.98%   69.97%   -0.01%     
===========================================
  Files          820      820              
  Lines        30631    30631              
  Branches      5153     5153              
===========================================
- Hits         21435    21431       -4     
+ Misses        7765     7761       -4     
- Partials      1431     1439       +8
Files with missing lines Coverage Δ
...rsistence/file/batch/PlainBatchFileReaderWriter.kt 75.68% <0.00%> (ø)

... and 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dd-mergequeue
dd-mergequeue Bot merged commit da39148 into develop May 15, 2025
@dd-mergequeue
dd-mergequeue Bot deleted the mconstantin/fix-error-log-message branch May 15, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes
@ambushwork ambushwork ambushwork approved these changes
@aleksandr-gringauz aleksandr-gringauz aleksandr-gringauz approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mariusc83 @codecov-commenter @0xnm @ambushwork @aleksandr-gringauz