RUM-9958: Fix datadog core creation in baseline benchmark run#2649
Merged
aleksandr-gringauz merged 1 commit intoMay 15, 2025
Merged
Conversation
aleksandr-gringauz
marked this pull request as ready for review
May 15, 2025 08:49
mariusc83
approved these changes
May 15, 2025
0xnm
approved these changes
May 15, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2649 +/- ##
===========================================
- Coverage 70.06% 70.04% -0.02%
===========================================
Files 820 820
Lines 30598 30598
Branches 5136 5136
===========================================
- Hits 21436 21430 -6
+ Misses 7733 7732 -1
- Partials 1429 1436 +7 🚀 New features to boost your workflow:
|
aleksandr-gringauz
deleted the
aleksandr-gringauz/RUM-9958/fix-crash-baseline
branch
May 15, 2025 09:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Unfortunately in my previous pr I made a mistake. All baseline benchmark runs started crashing (except session replay ones).
For example for LogsCustom scenario we still use
Loggerin baseline run link, but it should be the no-op one. When it gets created here, it requiressdkCore, that tries to get created but crashes here.Fix is to create a no-op core in baseline run.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)