Skip to content

RUM-9053: Support Coil3 for Session Replay image recording#2648

Merged
ambushwork merged 1 commit into
developfrom
yl/compose/coil3-support-pr
May 15, 2025
Merged

RUM-9053: Support Coil3 for Session Replay image recording#2648
ambushwork merged 1 commit into
developfrom
yl/compose/coil3-support-pr

Conversation

@ambushwork

@ambushwork ambushwork commented May 15, 2025

Copy link
Copy Markdown
Member

What does this PR do?

Due to the internal API change of Coil from V2 to V3, we were not able to retrieve the painter attribute as before, this PR adds a new way of resolving the painter in modifier node chain in Coil3 AsyncImage to retrieve the painter for Session Replay image recording.

Motivation

RUM-9053

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@ambushwork
ambushwork marked this pull request as ready for review May 15, 2025 07:35
@ambushwork
ambushwork requested review from a team as code owners May 15, 2025 07:35
0xnm
0xnm previously approved these changes May 15, 2025
View reviewed changes
Comment thread ...e/src/main/kotlin/com/datadog/android/sessionreplay/compose/internal/utils/SemanticsUtils.kt Outdated
@codecov-commenter

codecov-commenter commented May 15, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.94%. Comparing base (8be1d29) to head (64ac577).
⚠️ Report is 2093 commits behind head on develop.

Files with missing lines Patch % Lines
...onreplay/compose/internal/utils/ReflectionUtils.kt 0.00% 17 Missing ⚠️
...y/compose/internal/reflection/ComposeReflection.kt 0.00% 14 Missing ⚠️
...ionreplay/compose/internal/utils/SemanticsUtils.kt 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2648      +/-   ##
===========================================
- Coverage    70.06%   69.94%   -0.12%     
===========================================
  Files          820      820              
  Lines        30598    30631      +33     
  Branches      5136     5153      +17     
===========================================
- Hits         21436    21423      -13     
- Misses        7733     7761      +28     
- Partials      1429     1447      +18
Files with missing lines Coverage Δ
...ionreplay/compose/internal/utils/SemanticsUtils.kt 70.11% <0.00%> (-0.82%) ⬇️
...y/compose/internal/reflection/ComposeReflection.kt 0.00% <0.00%> (ø)
...onreplay/compose/internal/utils/ReflectionUtils.kt 1.37% <0.00%> (-0.42%) ⬇️

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

jonathanmos
jonathanmos previously approved these changes May 15, 2025
View reviewed changes
@ambushwork
ambushwork dismissed stale reviews from jonathanmos and 0xnm via 64ac577 May 15, 2025 07:44
@ambushwork
ambushwork force-pushed the yl/compose/coil3-support-pr branch from 2801f6a to 64ac577 Compare May 15, 2025 07:44
@ambushwork
ambushwork merged commit b84746f into develop May 15, 2025
@ambushwork
ambushwork deleted the yl/compose/coil3-support-pr branch May 15, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mariusc83 mariusc83 mariusc83 approved these changes
@0xnm 0xnm 0xnm approved these changes
@jonathanmos jonathanmos jonathanmos left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ambushwork @codecov-commenter @mariusc83 @0xnm @jonathanmos