RUM-9510: RumManual scenario for android benchmark app#2644
Merged
aleksandr-gringauz merged 1 commit intoMay 13, 2025
Merged
Conversation
aleksandr-gringauz
force-pushed
the
aleksandr-gringauz/RUM-9510/rummanual-scenario-android-benchmarks-2
branch
from
May 12, 2025 15:08
87efd8d to
acd58ee
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2644 +/- ##
===========================================
+ Coverage 70.05% 70.06% +0.01%
===========================================
Files 820 820
Lines 30598 30598
Branches 5136 5136
===========================================
+ Hits 21434 21437 +3
+ Misses 7735 7730 -5
- Partials 1429 1431 +2 🚀 New features to boost your workflow:
|
aleksandr-gringauz
marked this pull request as ready for review
May 12, 2025 15:53
0xnm
approved these changes
May 12, 2025
| is RumManualScenarioScreenAction.EventSendingTaskFinished -> { | ||
| if (prev.sendingTask != null) { | ||
| val (task, _) = prev.sendingTask | ||
| if (task === action.task) { |
Member
There was a problem hiding this comment.
is reference-based comparison here on purpose?
Contributor
Author
There was a problem hiding this comment.
Yes.
EventSendingTask acts as an identifier of the async job.
In case the previous job is still executing and managed to dispatch EventSendingTaskFinished while we already have a new one, we need to ignore this EventSendingTaskFinished from the old job.
It theoretically can happen if we click "cancel" and then "send" buttons very fast and the first job is already past its last coroutine cancellation point.
aleksandr-gringauz
deleted the
aleksandr-gringauz/RUM-9510/rummanual-scenario-android-benchmarks-2
branch
May 13, 2025 06:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implemented RumManual scenario for Android Benchmarking app that is described here. demo: link
created a synthetics test described here. Link. I checked that is works for my local build.
Some links to the results:
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)