Speed up some tests in FeatureScopeTest by reducing unconditional wait time#2643
Merged
0xnm merged 1 commit intoMay 13, 2025
Merged
Conversation
Datadog Summary✅ Code Quality ✅ Code Security ✅ Dependencies Was this helpful? Give us feedback! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2643 +/- ##
===========================================
- Coverage 70.06% 70.03% -0.03%
===========================================
Files 820 820
Lines 30591 30591
Branches 5136 5136
===========================================
- Hits 21432 21423 -9
Misses 7730 7730
- Partials 1429 1438 +9 🚀 New features to boost your workflow:
|
ambushwork
approved these changes
May 12, 2025
jonathanmos
approved these changes
May 13, 2025
0xnm
deleted the
nogorodnikov/speed-up-featurescopecore-instrumented-tests
branch
May 13, 2025 14:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Some instrumented tests in the
FeatureScopeTestare using unconditionalThread.sleepwith a wait time of 30 seconds.This PR brings some improvement in the execution time by introducing more precise waiting (but not eliminating it completely): now we will wait for the all write operations to complete before jumping to the assertion section and the only unconditional wait to use is the wait for the next upload cycle.
This is just a quick improvement, there is a TODO item to make it even better in the future.
Review checklist (to be filled by reviewers)