Skip to content

Catch exceptions during the Power or Battery broadcast intents processing#2642

Merged
0xnm merged 1 commit into
developfrom
nogorodnikov/catch-runtime-exception-during-power-battery-intent-processing
May 12, 2025
Merged

Catch exceptions during the Power or Battery broadcast intents processing#2642
0xnm merged 1 commit into
developfrom
nogorodnikov/catch-runtime-exception-during-power-battery-intent-processing

Conversation

@0xnm

@0xnm 0xnm commented May 12, 2025

Copy link
Copy Markdown
Member

What does this PR do?

It seems exceptions may be thrown (although very rarely) by the system during the Power or Battery intents processing, so this PR aims to catch and log them instead of crashing the host app.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested review from a team as code owners May 12, 2025 08:51
@datadog-datadog-prod-us1

Copy link
Copy Markdown

Datadog Summary

✅ Code Quality    ✅ Code Security    ✅ Dependencies


Was this helpful? Give us feedback!

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.99%. Comparing base (4df0cde) to head (bfb9889).

Files with missing lines Patch % Lines
...rnal/system/BroadcastReceiverSystemInfoProvider.kt 88.89% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2642      +/-   ##
===========================================
- Coverage    70.06%   69.99%   -0.07%     
===========================================
  Files          820      820              
  Lines        30591    30598       +7     
  Branches      5136     5136              
===========================================
- Hits         21432    21416      -16     
- Misses        7730     7745      +15     
- Partials      1429     1437       +8     
Files with missing lines Coverage Δ
...rnal/system/BroadcastReceiverSystemInfoProvider.kt 96.36% <88.89%> (-1.55%) ⬇️

... and 43 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aleksandr-gringauz

Copy link
Copy Markdown
Contributor

How did you find this? Was it some customer report?

@0xnm
0xnm merged commit b29f35c into develop May 12, 2025
@0xnm
0xnm deleted the nogorodnikov/catch-runtime-exception-during-power-battery-intent-processing branch May 12, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants