RUM-9509: Trace scenario for android benchmark app#2637
Merged
aleksandr-gringauz merged 2 commits intoMay 9, 2025
Merged
Conversation
aleksandr-gringauz
force-pushed
the
aleksandr-gringauz/RUM-9509/traces-benchmark-scenario
branch
from
May 8, 2025 13:25
2b780f6 to
62d43d1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2637 +/- ##
===========================================
- Coverage 70.05% 70.04% -0.01%
===========================================
Files 820 820
Lines 30568 30591 +23
Branches 5132 5136 +4
===========================================
+ Hits 21413 21427 +14
Misses 7726 7726
- Partials 1429 1438 +9 🚀 New features to boost your workflow:
|
aleksandr-gringauz
marked this pull request as ready for review
May 9, 2025 06:35
ambushwork
previously approved these changes
May 9, 2025
xgouchet
previously approved these changes
May 9, 2025
aleksandr-gringauz
dismissed stale reviews from xgouchet and ambushwork
via
May 9, 2025 07:18
4164398
Comment on lines
+30
to
+36
| val isTracingEnabled = config.run == SyntheticsRun.Instrumented && | ||
| config.scenario == SyntheticsScenario.Trace | ||
|
|
||
| val tracerProvider = when (isTracingEnabled) { | ||
| true -> OtelTracerProvider.Builder(sdkCore).build() | ||
| false -> TracerProvider.noop() | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Important. This was missing in my initial implementation. We need to provide a TracerProvider.noop() when we are in baseline run. Because otherwise it creates a working tracer that does some work under the hood. In the end the traces were not sent to the backend because Trace.enable wasn't called, but it was still doing some non-trivial work.
ambushwork
approved these changes
May 9, 2025
aleksandr-gringauz
deleted the
aleksandr-gringauz/RUM-9509/traces-benchmark-scenario
branch
May 9, 2025 12:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implemented Traces scenario for Android Benchmarking app that is described here. demo: link
created a synthetics test described here. Link. I checked that is works for my local build.
One of the traces from the synthetic test link.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)