RUM-9881: Push context changes from public API to the context thread#2635
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## nogorodnikov/rum-8170/feature-context-sync #2635 +/- ##
==============================================================================
- Coverage 70.12% 70.10% -0.02%
==============================================================================
Files 819 819
Lines 30590 30615 +25
Branches 5110 5111 +1
==============================================================================
+ Hits 21450 21460 +10
- Misses 7729 7744 +15
Partials 1411 1411
🚀 New features to boost your workflow:
|
Member
|
is it possible to add unit test to protect against the concurrency issue that you mentioned in the description? |
ambushwork
approved these changes
May 7, 2025
0xnm
force-pushed
the
nogorodnikov/rum-9881/push-context-changes-to-context-thread
branch
2 times, most recently
from
May 7, 2025 15:47
0ac0371 to
f51c7e9
Compare
jonathanmos
approved these changes
May 8, 2025
xgouchet
approved these changes
May 9, 2025
mariusc83
approved these changes
May 12, 2025
0xnm
force-pushed
the
nogorodnikov/rum-9881/push-context-changes-to-context-thread
branch
from
May 12, 2025 10:32
f51c7e9 to
1082f59
Compare
Member
Author
|
@ambushwork Good point, totally makes sense. I've added the necessary integration test. |
Datadog Summary✅ Code Quality ✅ Code Security ✅ Dependencies ❌ Pipelines Next StepsWas this helpful? Give us feedback! |
0xnm
force-pushed
the
nogorodnikov/rum-9881/push-context-changes-to-context-thread
branch
from
May 12, 2025 12:05
1082f59 to
8ec62e1
Compare
0xnm
force-pushed
the
nogorodnikov/rum-9881/push-context-changes-to-context-thread
branch
from
May 12, 2025 12:07
8ec62e1 to
7b11e61
Compare
ambushwork
approved these changes
May 12, 2025
0xnm
deleted the
nogorodnikov/rum-9881/push-context-changes-to-context-thread
branch
May 12, 2025 13:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
To align the sequence of context updates/reads caused by the SDK API calls, we need to update context on the context thread only, so that something like this is correct:
Review checklist (to be filled by reviewers)