RUM-9746: Resolve file orchestrator for write operation from DatadogContext#2624
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## nogorodnikov/rum-8170/feature-context-sync #2624 +/- ##
==============================================================================
+ Coverage 70.03% 70.07% +0.04%
==============================================================================
Files 818 818
Lines 30561 30557 -4
Branches 5129 5129
==============================================================================
+ Hits 21401 21410 +9
+ Misses 7724 7723 -1
+ Partials 1436 1424 -12
🚀 New features to boost your workflow:
|
ambushwork
approved these changes
Apr 30, 2025
mariusc83
approved these changes
May 2, 2025
0xnm
deleted the
nogorodnikov/rum-9746/resolve-write-orchestrator-from-datadogcontext
branch
May 2, 2025 08:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This change makes the logic to resolve file orchestrator for the event write operation to read tracking consent from
DatadogContextpassed withwithWriteContextcall instead of doing the resolution independently.This makes an alignment with iOS SDK.
Review checklist (to be filled by reviewers)