RUM-7956: Fix background session start reason#2623
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2623 +/- ##
===========================================
- Coverage 70.15% 70.06% -0.09%
===========================================
Files 820 820
Lines 30568 30568
Branches 5132 5132
===========================================
- Hits 21443 21417 -26
- Misses 7717 7723 +6
- Partials 1408 1428 +20
🚀 New features to boost your workflow:
|
jonathanmos
force-pushed
the
jmoskovich/rum-7956/background-launch
branch
from
April 30, 2025 08:29
683cd5b to
c1ad240
Compare
jonathanmos
marked this pull request as ready for review
May 5, 2025 06:41
0xnm
approved these changes
May 5, 2025
ambushwork
approved these changes
May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Sessions that expired and were renewed in the background didn't have the appropriate start reason - the reason was inactivity_timeout and should have been background_launch.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)