Skip to content

RUM-9720: Remove forceNewBatch API#2621

Merged
0xnm merged 1 commit into
nogorodnikov/rum-8170/feature-context-syncfrom
nogorodnikov/rum-9720/remove-force-new-batch-api
Apr 30, 2025
Merged

RUM-9720: Remove forceNewBatch API#2621
0xnm merged 1 commit into
nogorodnikov/rum-8170/feature-context-syncfrom
nogorodnikov/rum-9720/remove-force-new-batch-api

Conversation

@0xnm

@0xnm 0xnm commented Apr 29, 2025

Copy link
Copy Markdown
Member

What does this PR do?

This API was originally added as a workaround for the Session Replay intake requirement, but it is not used anymore, so it can be removed.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested review from a team as code owners April 29, 2025 08:46
@codecov-commenter

codecov-commenter commented Apr 29, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 70.06%. Comparing base (ef654e8) to head (b4d9bbc).
⚠️ Report is 224 commits behind head on nogorodnikov/rum-8170/feature-context-sync.

Files with missing lines Patch % Lines
...y/internal/storage/SessionReplayResourcesWriter.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@                              Coverage Diff                               @@
##           nogorodnikov/rum-8170/feature-context-sync    #2621      +/-   ##
==============================================================================
- Coverage                                       70.16%   70.06%   -0.10%     
==============================================================================
  Files                                             820      818       -2     
  Lines                                           30571    30561      -10     
  Branches                                         5132     5129       -3     
==============================================================================
- Hits                                            21449    21411      -38     
- Misses                                           7708     7726      +18     
- Partials                                         1414     1424      +10
Files with missing lines Coverage Δ
...in/com/datadog/android/core/internal/SdkFeature.kt 91.13% <100.00%> (ø)
...droid/core/internal/metrics/BatchClosedMetadata.kt 100.00% <ø> (ø)
...id/core/internal/metrics/BatchMetricsDispatcher.kt 95.95% <ø> (-0.05%) ⬇️
...droid/core/internal/persistence/AbstractStorage.kt 100.00% <ø> (ø)
...d/core/internal/persistence/ConsentAwareStorage.kt 97.70% <ø> (+1.66%) ⬆️
.../core/internal/persistence/FileEventBatchWriter.kt 98.15% <100.00%> (+0.53%) ⬆️
...ence/file/advanced/ConsentAwareFileOrchestrator.kt 93.75% <100.00%> (ø)
...al/persistence/file/batch/BatchFileOrchestrator.kt 93.55% <100.00%> (-0.16%) ⬇️
.../persistence/file/single/SingleFileOrchestrator.kt 75.00% <ø> (ø)
...y/internal/storage/SessionReplayResourcesWriter.kt 84.62% <0.00%> (ø)

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@0xnm
0xnm merged commit 10c7f1f into nogorodnikov/rum-8170/feature-context-sync Apr 30, 2025
@0xnm
0xnm deleted the nogorodnikov/rum-9720/remove-force-new-batch-api branch April 30, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambushwork ambushwork ambushwork approved these changes
@jonathanmos jonathanmos jonathanmos approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@0xnm @codecov-commenter @ambushwork @jonathanmos