RUM-9711: Resolve batch file only during the actual write call#2619
Merged
Conversation
0xnm
force-pushed
the
nogorodnikov/rum-9711/resolve-batch-file-only-during-write-call
branch
from
April 28, 2025 14:57
a29a393 to
d9d5cbd
Compare
0xnm
force-pushed
the
nogorodnikov/rum-9711/resolve-batch-file-only-during-write-call
branch
from
April 28, 2025 15:21
d9d5cbd to
00b3f6e
Compare
ambushwork
approved these changes
Apr 28, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## nogorodnikov/rum-8170/feature-context-sync #2619 +/- ##
==============================================================================
- Coverage 70.16% 70.11% -0.05%
==============================================================================
Files 820 820
Lines 30571 30571
Branches 5132 5130 -2
==============================================================================
- Hits 21449 21433 -16
- Misses 7708 7716 +8
- Partials 1414 1422 +8
🚀 New features to boost your workflow:
|
jonathanmos
approved these changes
Apr 29, 2025
0xnm
deleted the
nogorodnikov/rum-9711/resolve-batch-file-only-during-write-call
branch
April 29, 2025 08:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is a first step for a better feature context synchronization: we are resolving batch file at the beginning of the
withWriteContextcall, but instead this PR moves this resolution to the point where the actual write happens, so that later we can better separate event processing and event writing stages.Review checklist (to be filled by reviewers)