Integrate Datadog Plugin in benchmark application#2618
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2618 +/- ##
===========================================
- Coverage 70.16% 70.06% -0.10%
===========================================
Files 820 820
Lines 30571 30571
Branches 5132 5132
===========================================
- Hits 21449 21418 -31
- Misses 7708 7724 +16
- Partials 1414 1429 +15 🚀 New features to boost your workflow:
|
ambushwork
marked this pull request as ready for review
April 28, 2025 15:32
0xnm
approved these changes
Apr 28, 2025
| BottomNavigationBar(navHostController = navController) | ||
| } | ||
| ) { padding -> | ||
| NavigationViewTrackingEffect( |
Contributor
There was a problem hiding this comment.
why was it necessary to remove this?
Member
Author
There was a problem hiding this comment.
Because this is the API that we need to auto instrument with kotlin compiler plugin, we need to remove the manual instrumentation here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use 1.17.0-rc1 Datadog Plugin in Benchmark application for Compose auto-instrumentation
Review checklist (to be filled by reviewers)