RUM-9410 Remove the noisy warning log as for some views is normal to not have itv#2617
Merged
Merged
Conversation
0xnm
previously approved these changes
Apr 24, 2025
ambushwork
previously approved these changes
Apr 24, 2025
…not have itv metric
mariusc83
force-pushed
the
mconstantin/rum-9410/investigate-itv-logic
branch
from
April 24, 2025 12:57
342512e to
0ec7861
Compare
0xnm
approved these changes
Apr 24, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2617 +/- ##
===========================================
- Coverage 69.97% 69.94% -0.03%
===========================================
Files 820 820
Lines 30554 30549 -5
Branches 5130 5129 -1
===========================================
- Hits 21379 21365 -14
- Misses 7747 7751 +4
- Partials 1428 1433 +5
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…not have itv metric
What does this PR do?
I performed a thorough functionality check on the way we resolve the ITV metric and everything seems to work fine. I chose to remove the noisy log when the metric could not be resolved as for some views (especially the first ones that are loaded automatically without any user interaction) this behaviour is normal.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)